Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE IN A MINOR: v1.3.0 breaks on edition 2017. 1.2.x does not. #20

Closed
ljharb opened this issue Oct 11, 2016 · 4 comments
Closed

Comments

@ljharb
Copy link

ljharb commented Oct 11, 2016

We use ecmaVersion 2017 in our project, and v1.3.0 breaks on this with:

$PWD/node_modules/chai-enzyme/node_modules/react-element-to-jsx-string/node_modules/sortobject/node_modules/editions/es2015/index.js:168
    throw new DetailedError('There are no suitable editions for this environment:', { opts: opts, editions: editions, failures: editionFailures });

However, when I peg to v1.2.x of editions, it does not.

Please revert this breaking change in a minor version :-/

@balupton
Copy link
Member

Will unpublish the version now, can you ping me on skype - balupton - and we can debug the cause

@balupton
Copy link
Member

Unpublished:

$ npm unpublish editions@1.3.0 --force
npm WARN using --force I sure hope you know what you are doing.
- editions@1.3.0

Debugging now.

@ljharb
Copy link
Author

ljharb commented Oct 11, 2016

Thanks! I'll ping you on skype; sadly it's not a public project so we'll have to debug by proxy.

@ljharb
Copy link
Author

ljharb commented Oct 11, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants