Skip to content

Commit d99bf85

Browse files
authored
Merge pull request #7 from jonnitto/master
Improvements for Javascript asset
2 parents 8d1967a + 2af64ab commit d99bf85

File tree

6 files changed

+310
-440
lines changed

6 files changed

+310
-440
lines changed

Resources/Private/Assets/Main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ document.addEventListener('click', function(event) {
3838
EMBED_ELEMENT.innerHTML = JSON.parse(CONTAINER.dataset.embedHtml);
3939

4040
// Run trough every script and active it
41-
[...EMBED_ELEMENT.querySelectorAll('script')].forEach(scriptTag => {
41+
Array.from(EMBED_ELEMENT.querySelectorAll('script')).forEach(scriptTag => {
4242
if (scriptTag.src) {
4343
const TAG = document.createElement('script');
4444
TAG.src = scriptTag.src;

Resources/Public/Main.js

+1-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Resources/Public/Main.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+3-4
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,15 @@
88
"url": "git://github.com/betterembed/neos-betterembed.git"
99
},
1010
"devDependencies": {
11-
"@babel/core": "^7.8.7",
12-
"@babel/preset-env": "^7.8.7",
11+
"@babel/core": "^7.9.0",
12+
"@babel/preset-env": "^7.9.0",
1313
"autoprefixer": "^9.7.4",
1414
"cssnano": "^4.1.10",
1515
"join-array": "^1.1.2",
1616
"postcss-banner": "^3.0.1",
1717
"postcss-cli": "^7.1.0",
18-
"rollup": "^1.32.1",
18+
"rollup": "^2.1.0",
1919
"rollup-plugin-babel": "^4.4.0",
20-
"rollup-plugin-license": "^0.13.0",
2120
"rollup-plugin-terser": "^5.3.0",
2221
"sass": "^1.26.3"
2322
},

rollup.config.js

+8-19
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import babel from 'rollup-plugin-babel';
22
import { terser } from 'rollup-plugin-terser';
3-
import license from 'rollup-plugin-license';
43
import joinArray from 'join-array';
54
import composer from './composer.json';
65

@@ -9,29 +8,19 @@ const AUTHORS = joinArray({
98
max: 4
109
});
1110

12-
const BANNER_CONTENT = `${composer.extra.neos['package-key']} - created by ${AUTHORS}
13-
@link ${composer.homepage}
14-
Copyright ${parseInt(new Date().getFullYear(), 10)} ${AUTHORS}
15-
Licensed under ${composer.license}`;
11+
const BANNER_CONTENT = `/*!
12+
* ${composer.extra.neos['package-key']} - created by ${AUTHORS}
13+
* @link ${composer.homepage}
14+
* Copyright ${parseInt(new Date().getFullYear(), 10)} ${AUTHORS}
15+
* Licensed under ${composer.license}
16+
*/`;
1617

1718
export default [
1819
{
1920
input: 'Resources/Private/Assets/Main.js',
20-
plugins: [
21-
babel(),
22-
terser({
23-
output: {
24-
comments: false
25-
}
26-
}),
27-
license({
28-
banner: {
29-
content: BANNER_CONTENT,
30-
commentStyle: 'ignored'
31-
}
32-
})
33-
],
21+
plugins: [babel(), terser()],
3422
output: {
23+
banner: BANNER_CONTENT,
3524
sourcemap: true,
3625
file: 'Resources/Public/Main.js',
3726
format: 'iife'

0 commit comments

Comments
 (0)