Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude should not remove excluded files if deleteOrphaned is true #97

Closed
Nef10 opened this issue Sep 5, 2021 · 2 comments · Fixed by #98
Closed

Exclude should not remove excluded files if deleteOrphaned is true #97

Nef10 opened this issue Sep 5, 2021 · 2 comments · Fixed by #98
Labels
bug Something isn't working released

Comments

@Nef10
Copy link
Contributor

Nef10 commented Sep 5, 2021

🐞 Describe the bug

Files which are excluded are still being deleted if deleteOrphaned is true.

This seems to be an edge case when using deleteOrphaned and excluded. However I still think it is a bug, at least not the behaviour I am expecting.

📚 To Reproduce

  1. Create a sync for a folder
  2. Set deleteOrphaned to true
  3. Exclude a specific file in this folder, which is not present
  4. Sync to a repo where this file is present

💡 Expected behavior

The file should not be deleted.

🖼️ Screenshots

Screen Shot 2021-09-04 at 9 01 30 PM

Screen Shot 2021-09-04 at 9 01 10 PM

⚙️ Environment

@v1 (using 1.12.0)
@Nef10 Nef10 added the bug Something isn't working label Sep 5, 2021
@Nef10 Nef10 mentioned this issue Sep 5, 2021
Merged
@BetaHuhn
Copy link
Owner

BetaHuhn commented Sep 5, 2021

Yep, that seems to be a bug. Thanks for reporting and for the PR.

Will merge it later today.

@BetaHuhn BetaHuhn linked a pull request Sep 6, 2021 that will close this issue
Do not delete excluded files if deleteOrphaned is true #98
Merged
@BetaHuhnBot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@thomasLeclaire thomasLeclaire mentioned this issue Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not delete excluded files if deleteOrphaned is true
3 participants
@Nef10 @BetaHuhn @BetaHuhnBot