Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program crashed while export to csv log file #501

Closed
hyperion11 opened this issue Mar 9, 2021 · 6 comments · Fixed by #504
Closed

Program crashed while export to csv log file #501

hyperion11 opened this issue Mar 9, 2021 · 6 comments · Fixed by #504
Labels

Comments

@hyperion11
Copy link

link to log file
https://1drv.ms/u/s!AuFPVI_eDaZbhY1C00z8whcSC4KQIQ?e=BjV6gV
try stable 3.5.0 and latest nightly. Same problem - program crash.
FC Omnibus F4, fw Betaflight 4.2.5

@McGiverGim
Copy link
Member

I have tested a 3.5 version and it has worked. I've tested latest master and it has crashed.

Maybe some memory problem, your file generates a 244Mb CSV file that we keep in memory to download.

I will test if I can find something that makes it less stable.

@McGiverGim
Copy link
Member

I can confirm... my 3.5 version worked because it was a custom 64 bit version build.

Export to CSV your file takes more than 3Gb of memory. I optimized a little the code some time ago, but is clear that it needs more work on it. The 64bit of the Blackbox can work with it, the 32bit not and crashes.

On the other side, @mikeller maybe is time to publish a x64 version. I doubt there is too much people using 32bit Windows versions now. We don't support Windows XP or Windows 7 anymore... What do you think?

@McGiverGim McGiverGim added the bug label Mar 11, 2021
@hyperion11
Copy link
Author

64bit windows version will be good solution i think.

@mikeller
Copy link
Member

@McGiverGim:

On the other side, @mikeller maybe is time to publish a x64 version.

Yeah, I think we can switch to publishing the 64 bit version for Windows.

@McGiverGim
Copy link
Member

@hyperion11 I have pushed a PR to migrate to win64. Once merged the nightlies versions of the Blackbox Log Viewer will be 64bit versions.

Until then, if you want to test it I think you can download it from here is where Azure has published the artifact, but will only be available for some time.

@haslinghuis
Copy link
Member

haslinghuis commented May 14, 2021

For those still using 32bit Windows use this instruction to build it yourself:

  1. Install the Nodejs from here: https://nodejs.org/dist/latest-v10.x/node-v10.24.1-x86.msi
  2. Clone the betaflight configurator (see the project for instructions, can also copy and expand the zip if not using git)
  3. Step into the project directory using cmd and use
yarn install
yarn release --win32

Output will speak for itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants