[BUG] v1.09_17 always attempts to download Java 8u51

[mojontwins]

Describe the bug
I am running the portable jar by double clicking. It launches using the only JRE installed, which is the one included in the latest Java 8 update from Oracle. This also happens if I have a different JDK/JRE installed, such as Zulu.

When I attempt to launch an instance, it downloads and installs Java 8u51 inside the .betacraft folder, then fails to launch the instance. No matter if I leave the instance "Java executable" blank or configure it manually, it just downloads Java 8u51 again and changes my setting.

To Reproduce
Steps to reproduce the behavior:

1. run portable launcher by double clicking on jar
2. Select my prefered instance
3. Click on Play
4. Downloading takes forever, it downloads and installs Java 8u51 inside the .betacraft folder inside .betacraft/java-8u51

Expected behavior
The game runs as it used to

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• Windows 10

• 1.09_17

• Processor architecture: x86_64

Additional context
Add any other context about the problem here.

[Moresteck]

Attach game logs

[mojontwins]

Not very long

[2025-02-07 11:29:44] OUT BetaCraft Launcher JE v1.09_17 loading...
[2025-02-07 11:29:44] OUT Java version: Oracle Corporation, Java(TM) SE Runtime Environment, 1.8.0_441-b07
[2025-02-07 11:29:44] OUT Portable: true
[2025-02-07 11:29:44] OUT EXE: false
[2025-02-07 11:29:44] OUT Prerelease: false
[2025-02-07 11:29:44] OUT Nightly: false
[2025-02-07 11:29:44] OUT Loaded in: 1146966000 ns
[2025-02-07 11:29:45] OUT Download started from: http://files.betacraft.uk/launcher/assets/lang/1.09_17/English.txt
[2025-02-07 11:29:55] OUT Download started from: http://files.betacraft.uk/launcher/assets/jsons/1.2.5_forge.info
[2025-02-07 11:29:57] OUT [D:\Juegos\Betacraft Portable\.betacraft\java-8u51\bin\java.exe, -XX:HeapDumpPath=java.exe_minecraft.exe.heapdump, -Djava.util.Arrays.useLegacyMergeSort=true, -Dhttp.nonProxyHosts=api.betacraft.uk|files.betacraft.uk|checkip.amazonaws.com, -Xmx512M, -Dhttp.proxyHost=betacraft.uk, -cp, D:\Juegos\Betacraft Portable\.betacraft\launcher\betacraft_wrapper.jar;D:\Juegos\Betacraft Portable\.betacraft\launcher\discord_rpc.jar, org.betacraft.launcher.Launcher, wrap, Popoch, -, -, -, -, 1.2.5  modded  mo]
[2025-02-07 11:29:57] ERR A critical error has occurred while attempting to launch the game!
java.io.IOException: Cannot run program "D:\Juegos\Betacraft Portable\.betacraft\java-8u51\bin\java.exe" (in directory "E:\Juegos\Betacraft Portable\.betacraft\1.2.5  modded  mo"): CreateProcess error=267, El nombre del directorio no es válido
	at java.lang.ProcessBuilder.start(Unknown Source)
	at org.betacraft.launcher.Launcher.launchGame(Launcher.java:679)
	at org.betacraft.launcher.Launcher.launchGame(Launcher.java:544)
	at org.betacraft.launcher.Window$11.run(Window.java:363)
Caused by: java.io.IOException: CreateProcess error=267, El nombre del directorio no es válido
	at java.lang.ProcessImpl.create(Native Method)
	at java.lang.ProcessImpl.<init>(Unknown Source)
	at java.lang.ProcessImpl.start(Unknown Source)
	... 4 more
[2025-02-07 11:30:08] OUT Options window opened.
[2025-02-07 11:30:26] OUT Saved instance: 1.2.5  modded  mo
[2025-02-07 11:30:29] OUT Options window opened.
[2025-02-07 11:30:32] OUT Saved instance: 1.2.5  modded  mo
[2025-02-07 11:30:34] OUT Download started from: http://files.betacraft.uk/launcher/assets/jsons/1.2.5_forge.info
[2025-02-07 11:32:16] OUT Saved instance: 1.2.5  modded  mo
[2025-02-07 11:32:18] OUT [D:\Juegos\Betacraft Portable\.betacraft\java-8u51\bin\java.exe, -XX:HeapDumpPath=java.exe_minecraft.exe.heapdump, -Djava.util.Arrays.useLegacyMergeSort=true, -Dhttp.nonProxyHosts=api.betacraft.uk|files.betacraft.uk|checkip.amazonaws.com, -Xmx512M, -Dhttp.proxyHost=betacraft.uk, -cp, D:\Juegos\Betacraft Portable\.betacraft\launcher\betacraft_wrapper.jar;D:\Juegos\Betacraft Portable\.betacraft\launcher\discord_rpc.jar, org.betacraft.launcher.Launcher, wrap, Popoch, -, -, -, -, 1.2.5  modded  mo]
[2025-02-07 11:32:18] ERR A critical error has occurred while attempting to launch the game!
java.io.IOException: Cannot run program "D:\Juegos\Betacraft Portable\.betacraft\java-8u51\bin\java.exe" (in directory "E:\Juegos\Betacraft Portable\.betacraft\1.2.5  modded  mo"): CreateProcess error=267, El nombre del directorio no es válido
	at java.lang.ProcessBuilder.start(Unknown Source)
	at org.betacraft.launcher.Launcher.launchGame(Launcher.java:679)
	at org.betacraft.launcher.Launcher.launchGame(Launcher.java:544)
	at org.betacraft.launcher.Window$11.run(Window.java:363)
Caused by: java.io.IOException: CreateProcess error=267, El nombre del directorio no es válido
	at java.lang.ProcessImpl.create(Native Method)
	at java.lang.ProcessImpl.<init>(Unknown Source)
	at java.lang.ProcessImpl.start(Unknown Source)
	... 4 more
[2025-02-07 11:32:42] OUT Options window opened.
[2025-02-07 11:33:45] OUT Options window opened.
[2025-02-07 11:38:37] OUT Instances list window opened.
[2025-02-07 11:38:44] OUT Download started from: http://files.betacraft.uk/launcher/assets/jsons/a1.2.6.info
[2025-02-07 11:39:06] OUT Disabling...

[mojontwins]

I understand that the problem is my instance, which has spaces. But why does it download another JRE?

[Moresteck]

It downloads Java 8u51 because it has detected you have Intel graphics, and any newer Java 8 build is likely to crash on startup, or have poor performance