Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppeteer-extra-plugin-block-resources is incompatible with puppeteer-extra-plugin-adblocker (Error: Request is already handled!) #373

Closed
Alfagun74 opened this issue Nov 12, 2020 · 1 comment

Comments

@Alfagun74
Copy link

puppeteer-extra-plugin-block-resources is incompatible with puppeteer-extra-plugin-adblocker.

I want to use those two plugins together to efficiently filter out unnecessary resources (images, fonts, css), annoying trackers and bad ad domains. But i get tons of UnhandledPromiseRejectionWarning: Error: Request is already handled! Errors when doing it. The reason is that the Packages "steal" the requests from each other and handle them, so the other one can't.

Why wont we just combine those two packages to one? For example using a blockAds & blockTracker option in the block-resources plugin. Or maybe make a third package, that supports both simultaneously. ¯_(ツ)_/¯

To go even further i unfortunately can't even handle any page.on("request") manually anymore using either one of those. So i need this feature to use both of these plugins, or i cant use any of them and just handle everything manually.

@berstend
Copy link
Owner

berstend commented Nov 14, 2020

Duplicate of #352 #364

@berstend berstend marked this as a duplicate of #364 Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants