Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean up #7

Closed
5 tasks done
alex404 opened this issue Oct 13, 2024 · 0 comments
Closed
5 tasks done

Code clean up #7

alex404 opened this issue Oct 13, 2024 · 0 comments
Assignees
Labels
Bug Something behaves in a way it shouldn't Refactor Improving code without changing function

Comments

@alex404
Copy link
Contributor

alex404 commented Oct 13, 2024

Some general clone clean up that should be addressed:

  • Better location for wandb dir
  • The warning logger.warning("Length of on-the-fly transformed dataset is not really fixed.") is popping up too much. Try to decide if this is strictly necessary.
  • The complete run config (i.e. result of ... --cfg job --resolve) is not being logged on wandb. It should be.
    • Problem seems to be more of a wandb bug. When settings subconfigs (e.g. optimizer=class-recon) for single runs, it will correctly fill out the dictionary on wandb.ai, but somehow subconfig dicts are getting overwritten with key names during sweeps. Seems like a bug that may resolve itself.
  • Torchinfo output should be dumped to a file on initialization.
  • Fix command=clean not really detecting the existence of the dir properly
    • The problem is actually that even scan creates a directory, which isn't great but I'm not sure is worth avoiding.
@alex404 alex404 self-assigned this Oct 16, 2024
@alex404 alex404 added Refactor Improving code without changing function Bug Something behaves in a way it shouldn't labels Oct 22, 2024
@alex404 alex404 mentioned this issue Oct 23, 2024
@alex404 alex404 closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something behaves in a way it shouldn't Refactor Improving code without changing function
Projects
None yet
Development

No branches or pull requests

1 participant