Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dockerized API Server in artifact integration test #891

Closed
parano opened this issue Jul 13, 2020 · 1 comment
Closed

Test dockerized API Server in artifact integration test #891

parano opened this issue Jul 13, 2020 · 1 comment
Labels
help-wanted An issue currently lacks a contributor

Comments

@parano
Copy link
Member

parano commented Jul 13, 2020

There are currently 3 model artifact integration tests under the test/integration/ directory: https://github.com/bentoml/BentoML/tree/e656c2d79965535eaa8228f925b0578520038528/tests/integration

We currently only test saving and then loading a BentoService with the artifact type being tested within the same python session. We would like to extend the coverage to fully testing the generated API server docker image, and make sure the artifact can be loaded in the docker environment, and the API server is functioning as expected.

See related discussions here: #876

Related tickets for more artifact integration tests:

cc @joshuacwnewton

@parano parano added help-wanted An issue currently lacks a contributor test labels Jul 13, 2020
@joshuacwnewton
Copy link
Contributor

joshuacwnewton commented Jul 22, 2020

Hi @parano! Thanks for the tag. Just commenting to say I've started to work on this, so feel free to assign me! My plan is to start with the updated #721, and once that looks good, continue on to other artifact types. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted An issue currently lacks a contributor
Projects
None yet
Development

No branches or pull requests

3 participants