Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YataiService monitoring and prometheus endpoint #1060

Closed
parano opened this issue Sep 3, 2020 · 4 comments · Fixed by #1284 or #1568
Closed

YataiService monitoring and prometheus endpoint #1060

parano opened this issue Sep 3, 2020 · 4 comments · Fixed by #1284 or #1568

Comments

@parano
Copy link
Member

parano commented Sep 3, 2020

Currently, there is no easy way to monitor a YataiService deployment.

  • Add a '/healthz' HTTP endpoint via the node server, in addition to te gRPC health check endpoint
  • Add a '/metrics' HTTP endpoint via the node server, and allow expose metrics from the python gRPC server
@aarnphm
Copy link
Contributor

aarnphm commented Oct 4, 2020

I would love to take this on

@CallmeMehdi
Copy link
Contributor

Hello @parano, I am currently working on this issue, I just wanted to ask, what does the endpoint /healthz do exactly? Thank you!

@parano
Copy link
Member Author

parano commented Oct 24, 2020

Hi @CallmeMehdi - I think @aarnphm is currently working on this issue as well, maybe you two can sync up and discuss?

"/healthz" endpoint is a convention in building microservices, sometimes a deployed service can get into a bad state and become incapable of handling requests. "/healthz" is a special endpoint that let the monitoring system to discover such failed service instance and do something about it(usually restarting the instance)

Implementing the healthz endpoint is usually very straightforward, e.g. https://cloud.ibm.com/docs/node?topic=node-node-healthcheck

@yubozhao
Copy link
Contributor

@CallmeMehdi @aarnphm Any update on this issue? Let me know if you are running into any issues, happy to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants