Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeTask timeouts are now ignored as these were not able to be implemented correctly #555

Closed
sedubois opened this issue Apr 5, 2022 · 1 comment · Fixed by #557
Closed

TimeTask timeouts are now ignored as these were not able to be implemented correctly #555

sedubois opened this issue Apr 5, 2022 · 1 comment · Fixed by #557

Comments

@sedubois
Copy link

sedubois commented Apr 5, 2022

My rails server using GoodJob 2.11.3 now shows the above warning upon startup. The warning disappears when removing GoodJob (when commenting out config.active_job.queue_adapter = :good_job).

It appears that the warning is thrown by concurrent-ruby when using the option timeout or timeout_interval.
@bensheldon
Copy link
Owner

oh, that's annoying. Thanks for reporting that. I'll fix it.

@bensheldon bensheldon mentioned this issue Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove usage of Concurrent::TimerTask's timeout_interval bensheldon/good_job
2 participants
@bensheldon @sedubois