Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Dashboard] count isn't following by the filter #1376

Closed
hotrungnhan opened this issue Jun 15, 2024 · 5 comments
Closed

[BUG] [Dashboard] count isn't following by the filter #1376

hotrungnhan opened this issue Jun 15, 2024 · 5 comments

Comments

@hotrungnhan
Copy link

hotrungnhan commented Jun 15, 2024

You guy can look at the picture, job count currently is the sum of all queues, intstead of filter by queues manga
image

@hotrungnhan hotrungnhan changed the title [BUG] [Dashboard] Job count isn't changes following the filter [BUG] [Dashboard] Job count isn't following by the filter Jun 15, 2024
@hotrungnhan hotrungnhan changed the title [BUG] [Dashboard] Job count isn't following by the filter [BUG] [Dashboard] count isn't following by the filter Jun 15, 2024
@bensheldon
Copy link
Owner

Thanks for opening the issue. Would you want to try updating the counts to use the appropriately filtered query? Here's where they're calculated:

@_states ||= begin
query = filtered_query(params.except(:state))
{
'scheduled' => query.scheduled.count,
'retried' => query.retried.count,
'queued' => query.queued.count,
'running' => query.running.count,
'succeeded' => query.succeeded.count,
'discarded' => query.discarded.count,
}
end

@hotrungnhan
Copy link
Author

Thanks for opening the issue. Would you want to try updating the counts to use the appropriately filtered query? Here's where they're calculated:

@_states ||= begin
query = filtered_query(params.except(:state))
{
'scheduled' => query.scheduled.count,
'retried' => query.retried.count,
'queued' => query.queued.count,
'running' => query.running.count,
'succeeded' => query.succeeded.count,
'discarded' => query.discarded.count,
}
end

i've try this weekend.

@bensheldon
Copy link
Owner

Sorry, this is fixed in #1373. I will release shortly.

@hotrungnhan
Copy link
Author

Really appreciate yours @bensheldon and @SebouChu efforts, you're guy are making a really goods library, can't wait to apply it in my products.

Now we can close this issue.

@github-project-automation github-project-automation bot moved this from Inbox to Done in GoodJob Backlog v2 Jun 21, 2024
@SebouChu
Copy link
Contributor

@hotrungnhan Haha, thanks, but all goes to @bensheldon, I'm just a small contributor 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants