Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment variable to mirror cleanup_preserved_jobs --before-seconds-ago=SECONDS #110

Closed
bensheldon opened this issue Aug 28, 2020 · 1 comment
Closed

Add environment variable to mirror cleanup_preserved_jobs --before-seconds-ago=SECONDS #110

bensheldon opened this issue Aug 28, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bensheldon
Copy link
Owner

The CLI should have an environment variable option for all parameters. cleanup_preserved_jobs --before-seconds-ago=SECONDS is missing an environment variable option.

Add GOOD_JOB_CLEANUP_PRESERVED_JOBS_BEFORE_SECONDS_AGO as an environment variable that defers to the parameter.
@bensheldon bensheldon added enhancement New feature or request good first issue Good for newcomers labels Aug 28, 2020
@gadimbaylisahil gadimbaylisahil mentioned this issue Aug 31, 2020
Merged
@gadimbaylisahil
Copy link
Contributor

I have finished with the PR including documentation change, please review 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bensheldon @gadimbaylisahil