Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GitHub Actions #669

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Implement GitHub Actions #669

merged 1 commit into from
Dec 19, 2020

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

Main differences to current CI (Travis):

  • using stock rebar3 instead of "latest" (don't know if this is a hard requirement)

Closes #668.

@benoitc
Copy link
Owner

benoitc commented Dec 8, 2020

thanks! I will check later this morning. What should I do to enable github actions?

@paulo-ferraz-oliveira
Copy link
Contributor Author

thanks! I will check later this morning. What should I do to enable github actions?

Two ways I can think of:
a. you merge to master - it'll be automatic, but this'll mean that whatever is not working will have to be fixed, either through master or a new pull request
b. you go to the Actions' tab, choose Erlang and commit an empty file to master; after that I'll rebase this pull request on top of master and we can make sure that what gets pushed was previously tested

Preferably you'd choose b) 😄

Copy link

@aleDsz aleDsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion ❤️

@benoitc
Copy link
Owner

benoitc commented Dec 16, 2020

thanks! I will check later this morning. What should I do to enable github actions?

Two ways I can think of:
a. you merge to master - it'll be automatic, but this'll mean that whatever is not working will have to be fixed, either through master or a new pull request
b. you go to the Actions' tab, choose Erlang and commit an empty file to master; after that I'll rebase this pull request on top of master and we can make sure that what gets pushed was previously tested

Preferably you'd choose b) 😄

Sorry for the late answer. I will do a proper commit today so we can test it. Thanks !

@benoitc
Copy link
Owner

benoitc commented Dec 17, 2020

Preferably you'd choose b) 😄

done :) I pushed an empty action file. Sorry for the delay... Go ahead anyway

@paulo-ferraz-oliveira
Copy link
Contributor Author

Rebased and force-pushed. 22.1.8.1 is not available. I'm removing it from the CI to check if the rest is OK.

@paulo-ferraz-oliveira
Copy link
Contributor Author

I'm removing kerl list installations from CI, since kerl is not available in the container. Is it absolutely required?

@paulo-ferraz-oliveira
Copy link
Contributor Author

@benoitc: let me know if you want some changes still. I'm using rebar3 from the checkouts since some of the versions bundled with the containers have bugs that would otherwise impact CI for no good reason.

@paulo-ferraz-oliveira
Copy link
Contributor Author

Oh, you might also want to remove Travis CI from the app, since it's no longer serving any particular purpose.

@benoitc
Copy link
Owner

benoitc commented Dec 19, 2020

I'm removing kerl list installations from CI, since kerl is not available in the container. Is it absolutely required?

not at all :) I will merge the PR , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move CI out of Travis-CI
3 participants