Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist is missing tox.ini #3267

Closed
mtelka opened this issue Aug 12, 2024 · 1 comment · Fixed by #3269
Closed

sdist is missing tox.ini #3267

mtelka opened this issue Aug 12, 2024 · 1 comment · Fixed by #3269

Comments

@mtelka
Copy link

mtelka commented Aug 12, 2024

The sdist package at PyPI is missing tox.ini. Please add the missing file to sdist to make downstream testing easier. Thank you.

@pajod
Copy link
Contributor

pajod commented Aug 12, 2024

If you want to test from sdist, you additionally want to apply our separately shipped .pylintrc (also currently in git, but not in sdist) or else it'll fail on stylistic checks otherwise suppressed. If we add those two and it fails later on, compare what you are doing to what .github/workflows/tox.yml is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants