Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive with default import having a "default" property #508

Closed
wants to merge 1 commit into from

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Aug 22, 2016

Fixes #507

@coveralls
Copy link

coveralls commented Aug 22, 2016

Coverage Status

Coverage increased (+0.003%) to 97.726% when pulling 084d229 on jquense:fix-507 into 7995581 on benmosher:master.

@jfmengels
Copy link
Collaborator

LGTM, thanks @jquense :)

@benmosher benmosher closed this in 0d98253 Aug 23, 2016
@benmosher benmosher added this to the 1.15.0 milestone Aug 23, 2016
@benmosher
Copy link
Member

Indeed, thanks much for a high-quality PR! 😎

@jfmengels
Copy link
Collaborator

jfmengels commented Aug 23, 2016

Only thing missing was adding thanks to yourself in the changelog, but we'll do that next time we update it 😄
(and also link to this PR in the changelog)
Thanks again!

@benmosher
Copy link
Member

@jfmengels I got it in the rebase: 0d98253#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR11 😁

Can't really blame folks for not wanting to thank themselves, I suppose... 😄

@jfmengels
Copy link
Collaborator

Truthfylly, I think it's odd to ask someone to thank themselves or add themselves to a contributors list. It's better done by the maintainers to show that your work is really appreciated :)

Btw, do you want to add a link to this PR in the changelog?

@jquense
Copy link
Contributor Author

jquense commented Aug 23, 2016

thanks y'all!

@benmosher
Copy link
Member

@jfmengels maybe we should start doing the changelog update in the merge commit instead of the PR. that would be less merge-conflict-prone, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants