New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support named TypeScript enums/interfaces/modules #958

Merged

ljharb merged 3 commits into import-js:master from spencerhakim:ts-nodes

Jan 17, 2018

Contributor

spencerhakim commented Oct 23, 2017

Addresses issues raised in #726 regarding TypeScript-specific AST nodes

coveralls commented Oct 23, 2017 •

edited

Loading

Coverage decreased (-0.04%) to 95.992% when pulling 3a7b412 on spencerhakim:ts-nodes into 98acd6a on benmosher:master.

spencerhakim force-pushed the ts-nodes branch from 3a7b412 to 65b1d50 Compare

October 23, 2017 20:48

coveralls commented Oct 23, 2017 •

edited

Loading

Coverage decreased (-0.04%) to 95.992% when pulling 65b1d50 on spencerhakim:ts-nodes into 98acd6a on benmosher:master.

Contributor Author

spencerhakim commented Nov 15, 2017

@ljharb Since you're the most recent person to show activity on this repo, can you review/merge this?

ljharb approved these changes

View reviewed changes

ljharb added the typescript label

Member

ljharb commented Nov 15, 2017

@spencerhakim looks like we need some more tests first, so coverage doesn't go down.

Contributor Author

spencerhakim commented Nov 15, 2017

@ljharb Look at my changes, I already added several tests to cover everything. I'm pretty sure it's just a false positive based on this line.

Member

ljharb commented Nov 17, 2017 •

edited

Loading

Which test covers a TSModuleDeclaration (or any of the other 3 types) without a TSExportKeyword?

Contributor Author

spencerhakim commented Nov 27, 2017

Right, didn't think that through. >_<

spencerhakim force-pushed the ts-nodes branch from e358c5c to bdc8a5f Compare

November 27, 2017 17:46

coveralls commented Nov 27, 2017

Coverage increased (+0.01%) to 96.098% when pulling bdc8a5f on spencerhakim:ts-nodes into 9db95b3 on benmosher:master.

3 similar comments

coveralls commented Nov 27, 2017

Coverage increased (+0.01%) to 96.098% when pulling bdc8a5f on spencerhakim:ts-nodes into 9db95b3 on benmosher:master.

coveralls commented Nov 27, 2017 •

edited

Loading

Coverage increased (+0.01%) to 96.098% when pulling bdc8a5f on spencerhakim:ts-nodes into 9db95b3 on benmosher:master.

coveralls commented Nov 27, 2017 •

edited

Loading

Coverage increased (+0.01%) to 96.098% when pulling bdc8a5f on spencerhakim:ts-nodes into 9db95b3 on benmosher:master.

coveralls commented Nov 27, 2017 •

edited

Loading

Coverage increased (+0.01%) to 96.098% when pulling bdc8a5f on spencerhakim:ts-nodes into 9db95b3 on benmosher:master.

ljharb requested review from benmosher and jfmengels

November 29, 2017 07:05

Contributor Author

spencerhakim commented Dec 14, 2017

@ljharb Bump, since this is passing.

Member

ljharb commented Dec 14, 2017

@spencerhakim the PR still needs reviews from other collabs

Member

ljharb commented Jan 4, 2018

@spencerhakim this will need a fresh rebase, which has some conflicts, i'm afraid.

spencerhakim added 2 commits

January 16, 2018 17:07


          Check for TSModuleDeclarations

c8d5e03


          Expanded/improved TS tests

7f35a3e

spencerhakim force-pushed the ts-nodes branch from bdc8a5f to 7f35a3e Compare

January 16, 2018 22:07


          Latest typescript and typescript-eslint-parser

69084df

Contributor Author

spencerhakim commented Jan 16, 2018

@ljharb After rebasing, this PR ended up being just a single line of actual new functionality, with the rest just being a bunch of new tests. Hope we can get it merged quickly once it passes CI.

ljharb approved these changes

View reviewed changes

coveralls commented Jan 17, 2018 •

edited

Loading

Coverage remained the same at 96.225% when pulling 69084df on spencerhakim:ts-nodes into c9269be on benmosher:master.

import-js deleted a comment from coveralls

ljharb merged commit 655c33d into import-js:master

ljharb mentioned this pull request

using "export interface" produces import/named error #726

Closed

renovate bot mentioned this pull request

Update dependency eslint-plugin-import to v2.11.0 Urigo/tortilla#68

Merged

renovate bot mentioned this pull request

Update eslint-plugin-import to 2.12.0 sbardian/DebtTrackerAPI#25

Merged

snyk-bot mentioned this pull request

[Snyk] Security upgrade nyc from 11.9.0 to 13.2.0 MaxMood96/eslint-plugin-import#4

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels