-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capybara-webkit doesn't work on Heroku #2
Comments
Hi Andrew - thanks for contributing! There is a base class /lib/google_ajax_crawler/drivers/driver.rb ... really all that is needed is to implement the following methods using phantom
The capybara-webkit driver does this by mixing in the Capybara::DSL.... |
Hello, |
Thanks @benkitzelman for getting back to me. Sorry I have been very slow to respond. I think @ChristopheBelpaire is right. We need to separate the driver gems from the core. I did a nasty hack job on my fork of ripping out Webkit and putting in Poltergeist. Not sure it is useful to salvage but I'd be happy to help split things. |
@ChristopheBelpaire Thanks for the effort on the Poltergeist driver, we are having too many issues with Capybara as well. I'm trying your branch, but in running the specs we get an error as |
oops forgot to git add . ;) |
yeah definitely a +1 on breaking out a separate gem - when its ready add a url to the crawler's readme pointing to the repo, and the name of the published rubygem :) |
Ok I'll do that, but maybe another gem for the capaybara-webkit driver should be created also, otherwise if I create a gem for phantom-js driver with dependencies to google-ajax-crawler I'll have dependencies on capybara-webkit (and webkit qt etc ...) and also phantom js. |
Ok I have first alpha version (witch seems to work for my app) here : https://github.com/ChristopheBelpaire/google_ajax_crawler_phantomjs |
@benkitzelman Are you still planning to break out the plugins? I'm trying to install @ChristopheBelpaire's plugin in Heroku, but I can't because it depends on your project, which depends on Qt... |
@vitorbaptista if you want, you can try this branch : https://github.com/ChristopheBelpaire/google-ajax-crawler/tree/poltergeist_driver witch use poltergeist instead of capybara webkit (without the dependencies). |
Cool, I'll try that later. Thanks :-) |
I'm having a lot of trouble installing even the main gem. My hope was to use the poltergeist_driver branch, but there may be some issues I'm having with the Ruby version (mine is Ruby 2) so I can't even get it to install properly. |
Any thoughts on how to get this working on Heroku? What would it take to add a phantomjs driver? Pretty sure that will run on Heroku.
The text was updated successfully, but these errors were encountered: