Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use globalThis when available rather than using Array as a namespace #347

Closed
erights opened this issue Jul 25, 2022 · 1 comment · Fixed by #359
Closed

Use globalThis when available rather than using Array as a namespace #347

erights opened this issue Jul 25, 2022 · 1 comment · Fixed by #359
Assignees
@benjamn

Comments

@erights
Copy link

erights commented Jul 25, 2022

Current behavior incompatible with Hardened JS. If run after lockdown it will fail to add a static property to the Array constructor. If run before lockdown, then lockdown will try to remove it because it is not on the Hardened JS whitelist (and should not be). If lockdown fails to remove it, then lockdown fails to create a Hardened JS system.

See endojs/endo#576 (comment)
@erights erights mentioned this issue Jul 25, 2022
Closed
@benjamn benjamn self-assigned this Jul 25, 2022
@benjamn benjamn mentioned this issue Aug 12, 2022
Merged
@benjamn benjamn linked a pull request Aug 12, 2022 that will close this issue
Avoid using Array constructor as a global namespace in @wry/context #359
Merged
@benjamn
Copy link
Owner

benjamn commented Aug 15, 2022

The changes from #359 (hopefully resolving this issue) are now available in version 0.7.0 of the @wry/context package. Thanks for opening this issue @erights!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamn benjamn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid using Array constructor as a global namespace in @wry/context benjamn/wryware
2 participants
@benjamn @erights