Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove name mappings for windows #26

Closed
vweevers opened this issue Nov 29, 2014 · 4 comments
Closed

Remove name mappings for windows #26

vweevers opened this issue Nov 29, 2014 · 4 comments
Milestone

Comments

@vweevers
Copy link

The winDetectMap should be updated, or removed all together. The "ff" to "firefox" mapping is old, as is "phantom" to "phantomjs". Chromium is not supported by win-detect-browsers (and chromium has no Windows installer as far as I know, so it's not detectable) so it can be left out. The only one that needs mapping is "chrome" to "google-chrome".

winDetectMap = {
  chrome: 'google-chrome',
  chromium: 'chromium-browser',
  ff: 'firefox',
  phantom: 'phantomjs',
  safari: 'safari',
  ie: 'ie',
  opera: 'opera'
};
@gregpabian
Copy link
Collaborator

Cool, again, a PR is welcome :)

@alessioalex
Copy link

I'll take care of that will my pull request for #24

@vweevers
Copy link
Author

vweevers commented Dec 2, 2014

@alessioalex great, thanks 👍

@gregpabian
Copy link
Collaborator

Resolved with bdb2ba0 and 217f212

@gregpabian gregpabian added this to the 0.4.5 milestone Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants