Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R interface? #7

Open
tdhock opened this issue Jan 16, 2020 · 3 comments
Open

R interface? #7

tdhock opened this issue Jan 16, 2020 · 3 comments
Labels
question Further information is requested

Comments

@tdhock
Copy link

tdhock commented Jan 16, 2020

Hi @rhysd my student @LooDaHu wants to try to get https://github.com/analyticalmonk/Rperform working with your software, but the docs say that user-defined tools are not yet supported. can you help explain how to get started?

Also can you explain how the authentication works? (how do we grant access for pushing benchmark data to gh-pages branch?)

Thanks

@rhysd
Copy link
Member

rhysd commented Jan 17, 2020

New tool support can be implemented as contribution for now. Please implement it and make a pull request.

Guide is here:

https://github.com/rhysd/github-action-benchmark/blob/master/CONTRIBUTING.md

And yesterday I merged Catch2 support PR from a contributor. Please see #6.

@rhysd rhysd added the question Further information is requested label Jan 20, 2020
@Robinlovelace
Copy link

Hi @rhysd I've just opened an issue on this on the R side: r-lib/bench#111

I'm up for taking a look at this no problem, you happy for me or others to comment and ask questions here if we hit any issues? Thanks!

@brainstorm
Copy link

brainstorm commented Jan 5, 2023

@tdhock, regarding to your question:

Also can you explain how the authentication works? (how do we grant access for pushing benchmark data to gh-pages branch?)

Read this

W.r.t getting started on how to contribute, have a look at my ongoing PR #145, that's an example on which files/functions you need to touch to add support for your Rperform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants