Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI runs are flaky #168

Closed
ktrz opened this issue Apr 26, 2023 · 2 comments · Fixed by #216 or #215
Closed

CI runs are flaky #168

ktrz opened this issue Apr 26, 2023 · 2 comments · Fixed by #216 or #215

Comments

@ktrz
Copy link
Member

ktrz commented Apr 26, 2023

Currently, CI runs on master are flaky and need a couple of restarts to finish properly
@ktrz ktrz mentioned this issue Jan 24, 2024
Closed
@ktrz
Copy link
Member Author

ktrz commented Jan 24, 2024

There might be a couple of underlying issues but so far I think the main issue is that if multiple benchmarks run concurrently and write results to the same place they might use a different version as a base to generate the changes and a different one to compare the changes to (the latter might have already been modified by another benchmark run)

The solution to this still needs some investigation

@ktrz
Copy link
Member Author

ktrz commented Jan 25, 2024

fixed by #215 and #216

@ktrz ktrz closed this as completed Jan 25, 2024
This was linked to pull requests Jan 25, 2024
fix: write with retry fails with separate repository #216
Merged
fix: improve flaky CI runs #215
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ktrz