Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Benchmark Hide-State to Perf-Plot URL #595

Open
VanDulti opened this issue Feb 27, 2025 · 1 comment
Open

Add Benchmark Hide-State to Perf-Plot URL #595

VanDulti opened this issue Feb 27, 2025 · 1 comment

Comments

@VanDulti
Copy link

When having a large number of related benchmarks (in my case ~200), the perf plot does take quite a long time to load. This comes with Bencher Console becoming somewhat unresponsive.
Obviously, ~200 benchmarks are to many for a single plot at the same time, but Bencher supports hiding and unhiding plots - making it reasonable to hide all of them initially and offer the option to unhide relevant ones or even all of them when needed.
I would propose persisting the hide-state in a project's plots by making it accessible from the plot url. This would allow me to further customize plots in iframes too.

@epompeii
Copy link
Member

@VanDulti thank you for using Bencher, and I'm sorry things aren't working as you expected.

The Perf Plots can support up to 255 permutations. However, as you've experienced this can take a while to load. I've done quite a bit of performance tuning on this front. Though I should probably take another look at it.

With that said, preventing this sort of usage was the primary motivation behind creating Pinned Plots. Have you tried setting up Pinned Plots instead of using one massive Perf Plot?

If so, what problems have you been running into and what makes you prefer the massive Perf Plot?

If not, could you help me understand why?

This would allow me to further customize plots in iframes too.

I'm curious, where are you using these iframes?

Is there a reason iframes for each set of the plot selections doesn't work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants