Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update Wiki page about Statistics #1779

Closed
lfgcampos opened this issue Sep 16, 2024 · 2 comments
Closed

[Docs] Update Wiki page about Statistics #1779

lfgcampos opened this issue Sep 16, 2024 · 2 comments

Comments

@lfgcampos
Copy link

While looking deep into Statistics, I found that the links for Prometheus are outdated.

Prometheus simple client went through a huge refactoring and the "old" simple_client only exists until version 0.16.0.
The new version, which started under version 1.x.x has a different package, classes and all.

Migration guide is well documented on their website: https://prometheus.github.io/client_java/migration/simpleclient/

Caffeine support was introduced recently: prometheus/client_java#983


What I want with this issue?

To simply update the Statistics page (https://github.com/ben-manes/caffeine/wiki/Statistics) with more info (if possible) but, at least, the correct new Prometheus link: https://github.com/prometheus/client_java/tree/main/prometheus-metrics-instrumentation-caffeine

Ben, maybe also adding a README to the new package/module would be nice :)

@ben-manes
Copy link
Owner

Thanks! Maybe we should link to their javadoc example?

@lfgcampos
Copy link
Author

Yes Ben, that is simple and efficient I'd say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants