This repository has been archived by the owner on Feb 4, 2018. It is now read-only.
feat(isBemEntityName): add isBemEntityName method
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadatuta
reviewed
Dec 10, 2016
|
|
||
| const entityName = new BemEntityName({ block: 'input' }); | ||
|
|
||
| BemEntityName.isBemEntityName(entityName); // true |
There was a problem hiding this comment.
Won't
const BemEntityName = require('@bem/entity-name');
const entityName = new BemEntityName({ block: 'input' });
entityName instanceof BemEntityName; // true
({}) instanceof BemEntityName; // falsebe enough?
There was a problem hiding this comment.
And if it's not for some reason let's rename the method to isInstanceOf?
There was a problem hiding this comment.
see #2
instanceof will not work with different versions of BemEntityName.
tadatuta
reviewed
Dec 11, 2016
| * BemEntityName.isBemEntityName({}); // false | ||
| */ | ||
| static isBemEntityName(entityName) { | ||
| return entityName && entityName.__isBemEntityName__; |
There was a problem hiding this comment.
return this.name === entityName.constructor.name;
tadatuta
reviewed
Dec 11, 2016
| * BemEntityName.isBemEntityName(entityName); // true | ||
| * BemEntityName.isBemEntityName({}); // false | ||
| */ | ||
| static isBemEntityName(entityName) { |
There was a problem hiding this comment.
and I still didn't get why not to call it isInstanceOf
qfox
approved these changes
Dec 11, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #64