This repository has been archived by the owner on Feb 4, 2018. It is now read-only.
Fix typings #113
Merged
Fix typings #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfox
reviewed
Apr 17, 2017
|
|
||
| const BemEntityName = require('../lib/entity-name'); | ||
| import BemEntityName from '..'; |
There was a problem hiding this comment.
может быть мы лучше отключим бабель в ava тестах?
There was a problem hiding this comment.
бабель пока обязательный, т.к. некоторые фичи завязаны на него
There was a problem hiding this comment.
"Пока" значит, что ситуация изменяется. Давай использовать только эти фичи? Или даже: мы можем не использовать эти фичи?
There was a problem hiding this comment.
@zxqfox в AVA сейчас нельзя отключить Babel, потому что есть фичи, которые работают на нём. Из-за этого опцию отключения Babel не запилили.
Мы, вроде бы, можем переопределить плагины бабеля, выкинув всё ненужное.
added 5 commits
April 20, 2017 20:56
It is necessary for types, that provides module with `export default`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.