Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number.isNaN not supported in IE11 #54

Closed
kyle-mccarthy opened this issue Apr 19, 2019 · 3 comments
Closed

Number.isNaN not supported in IE11 #54

kyle-mccarthy opened this issue Apr 19, 2019 · 3 comments

Comments

@kyle-mccarthy
Copy link

Describe the bug
Number.isNaN is not supported in IE11 but is used it https://github.com/bluebill1049/react-simple-img/blob/master/src/utils/getAspectRatio.js#L13

Expected behavior
Polyfill Number.isNaN or use alternative strategy

Desktop (please complete the following information):

  • Browser [e.g. chrome, safari] IE 11
@bluebill1049
Copy link
Member

bluebill1049 commented Apr 19, 2019 •
edited
Loading

thanks for reporting :) i have fixed the issue on https://github.com/bluebill1049/react-simple-img/releases/tag/v2.1.9

@kyle-mccarthy
Copy link
Author

Thanks for resolving this so quickly! The new version resolves the problem.

@bluebill1049
Copy link
Member

thank you for the star and support ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyle-mccarthy @bluebill1049