Change defaultConfig require path to relative #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeggse
approved these changes
Aug 5, 2020
This helps with bundling the application, as it's difficult to statically analyze an expression that invokes path.join.
skeggse
force-pushed
the
default-config-require-path-fix
branch
from
228eeb5 to
7fc577a
Compare
beequeueci
pushed a commit
that referenced
this pull request
Aug 5, 2020
### [3.0.2](v3.0.1...v3.0.2) (2020-08-05) ### Bug Fixes * use normal require path for defaultConfig ([#196](#196)) ([533f702](533f702))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you build the application with zeit/pkg you will not be able to run it due to a temporary snapshot path. Making it relative will allow pkg to ship the default config with the binary file.
Fixes following error:
(node:24280) UnhandledPromiseRejectionWarning: Error: Cannot find module '/snapshot/api/node_modules/bull-arena/src/server/config/index.json'