Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This plugin gets installed on Windows platforms #3

Closed
pke opened this issue Nov 21, 2016 · 7 comments
Closed

This plugin gets installed on Windows platforms #3

pke opened this issue Nov 21, 2016 · 7 comments

Comments

@pke
Copy link
Contributor

pke commented Nov 21, 2016

and then crashes.
Any way to prevent that?

@becvert
Copy link
Owner

becvert commented Nov 21, 2016

#2 would prevent that I think.
Someone may add support for the windows platform too

@pke
Copy link
Contributor Author

pke commented Nov 21, 2016

So, merge it then? Thanks ;)
I'll add Windows support later

@becvert
Copy link
Owner

becvert commented Nov 21, 2016

yes I should probably merge this.
but in theory nested js-module are for specialized javascript. which is not the case here.
I feel like js-module ought to be added for specified platforms only.
I'm investigating that issue.

@pke
Copy link
Contributor Author

pke commented Nov 21, 2016

Na, it solves the problem at hand. That's way better than just crashing the whole Cordova startup on Windows.

@pke
Copy link
Contributor Author

pke commented Nov 22, 2016

Created #4 with Windows support for you to merge.

@becvert
Copy link
Owner

becvert commented Nov 24, 2016

Thanks. I'll merge it soon.

@becvert
Copy link
Owner

becvert commented Nov 24, 2016

done. please close this issue if everything's fine with you.

@pke pke closed this as completed Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants