Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint and remove unused code #7

Open
OverLucker opened this issue Dec 30, 2020 · 2 comments
Open

Lint and remove unused code #7

OverLucker opened this issue Dec 30, 2020 · 2 comments

Comments

@OverLucker
Copy link

OverLucker commented Dec 30, 2020

Looks like the code is not used at all

public get RawData(): any {

export interface INetwork {

export interface IBasicNetwork extends INetwork {

export interface IWebRtcNetwork extends IBasicNetwork {

Also that would be great, if code had been performed in uniform style

@devluz
Copy link
Collaborator

devluz commented Dec 30, 2020

Can you recommend a good tool to ensure a uniform code style?

As for the unused code: The INetwork.ts is used in other projects as well. We can't really change it independently yet without a lot of code duplication. It would probably need an awrtc_common for anything that is shared between client, server and external applications. I keep this open though as a reminder.

@OverLucker
Copy link
Author

OverLucker commented Jan 2, 2021

That one will be sufficient

https://eslint.org/

In my project, I ended up with this config

{
    "env": {
        "browser": true,
        "es2021": true
    },
    "extends": [
        "google"
    ],
    "parser": "@typescript-eslint/parser",
    "parserOptions": {
        "ecmaVersion": 12
    },
    "plugins": [
        "@typescript-eslint"
    ],
    "rules": {
        "indent": ["error", 4],
        "max-len": ["warn", 120],
        "require-jsdoc": "warn"
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants