Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React v0.14.0-rc1 peerDependencie #10

Closed
LukevdPalen opened this issue Sep 25, 2015 · 5 comments
Closed

React v0.14.0-rc1 peerDependencie #10

LukevdPalen opened this issue Sep 25, 2015 · 5 comments

Comments

@LukevdPalen
Copy link

Could you add react 0.14.0-rc1 to the peerDependencies? Unfortunately react@>=0.11.0 <1.0.0 doesn't cover it.

@bebraw
Copy link
Owner

bebraw commented Sep 25, 2015

That sounds interesting. Can you suggest a better pattern? Is there any we can get alpha/beta/rc included? I tried against the online semver checker without any luck. It would suck having to add each alpha/beta/rc separately. I would rather have a range there.

@bebraw
Copy link
Owner

bebraw commented Sep 25, 2015

@LukevdPalen I had interesting conversation about the topic. I don't think there's a neat way to solve this through a range. We could add || sections to the rule but that would just push the problem to package.json.

As far as I can see the simplest solution would be for you to fork the library, tweak/eliminate the range and do npm i LukevdPalen/react-pagify -S. Once stable 0.14 gets out, you can drop it. I don't expect any major changes to react-pagify so I expect this could work quite nicely.

@LukevdPalen
Copy link
Author

No the most beautiful solution but >=0.13.* <1.0.0 || > 0.14.0-alpha should at least include the prerelease versions.

There is a threat going on at [https://github.com/facebook/react/issues/4542]

@bebraw bebraw closed this as completed in 3cadcef Sep 25, 2015
@bebraw
Copy link
Owner

bebraw commented Sep 25, 2015

0.8.2 contains the fix. I'm not totally happy about the solution as this needs to be tweaked again in the future but it's the best we can do at the moment.

@LukevdPalen
Copy link
Author

Thx! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants