Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on revive linter in golangci config #442

Open
carreter opened this issue Feb 2, 2024 · 1 comment
Open

Turn on revive linter in golangci config #442

carreter opened this issue Feb 2, 2024 · 1 comment
Labels
devops Improvements to DevOps (e.g. GitHub actions, linting, etc.) enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low priority Would be nice to fix, but doesn't have to happen right now/there are more important things stale

Comments

@carreter
Copy link
Collaborator

carreter commented Feb 2, 2024

Describe the desired feature/enhancement

Seems like golangci dropped support for golint a few versions ago. IMO, we should definitely have some sort of linting enabled!

Is your feature request related to a problem?

The problem: I cannot stand unlinted codebases!

Describe the solution you'd like

Add revive, a drop-in replacement for golint, to the list of enabled linters .golangci.yml.

This will require going through the entire codebase and fixing all of the errors until just lint is happy. Running golangci-lint -c .golangci.yml run --fix will take you part of the way there. It would probably also be good to add another entry to the justfile called lint-fix that runs golangci-lint -c .golangci.yml run --fix, or allow the user to pass additional arguments to the lint target (e.g. just lint --fix).

Describe alternatives you've considered (optional)

We could just leave the linter off, but that would make me sad :(

Additional context

Add any other context or screenshots about the feature request here.

@carreter carreter added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers devops Improvements to DevOps (e.g. GitHub actions, linting, etc.) low priority Would be nice to fix, but doesn't have to happen right now/there are more important things labels Feb 2, 2024
Copy link

github-actions bot commented Apr 3, 2024

This issue has had no activity in the past 2 months. Marking as stale.

@github-actions github-actions bot added the stale label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Improvements to DevOps (e.g. GitHub actions, linting, etc.) enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low priority Would be nice to fix, but doesn't have to happen right now/there are more important things stale
Projects
None yet
Development

No branches or pull requests

1 participant