Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genbank import and export from JSON should include feature sequences #388

Closed
Koeng101 opened this issue Oct 28, 2023 · 2 comments
Closed

Genbank import and export from JSON should include feature sequences #388

Koeng101 opened this issue Oct 28, 2023 · 2 comments
Labels
easy A quick and easy fix! enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low priority Would be nice to fix, but doesn't have to happen right now/there are more important things wontfix This will not be worked on

Comments

@Koeng101
Copy link
Contributor

Right now, it is a REAL pain to read location strings and properly parse. This makes it rather difficult to actually use JSON upstream or downstream from Golang. I think upon export, Genbank file features sequence should be exported.
@Koeng101 Koeng101 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers easy A quick and easy fix! low priority Would be nice to fix, but doesn't have to happen right now/there are more important things labels Oct 28, 2023
@abondrn abondrn mentioned this issue Oct 30, 2023
Closed
6 tasks
@TimothyStiles
Copy link
Collaborator

@Koeng101 is this a thing in the #339 refactor? I'm thinking maybe we should just use parameter structs for parsers and just have it be a flag when parsing?

@Koeng101
Copy link
Contributor Author

yes, it is.

we should just use parameter structs for parsers and just have it be a flag when parsing?

I'm a bit confused why, for this specifically. The data doesn't change at all when parsing, so why would we pass in a parameter struct into a parser containing information about the output JSON encoding for the downstream parsed structs?

@TimothyStiles TimothyStiles added the wontfix This will not be worked on label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy A quick and easy fix! enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low priority Would be nice to fix, but doesn't have to happen right now/there are more important things wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Koeng101 @TimothyStiles