Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test results summary #81

Merged
merged 18 commits into from
May 11, 2022
Merged

feat: test results summary #81

merged 18 commits into from
May 11, 2022

Conversation

eric-hc
Copy link
Contributor

@eric-hc eric-hc commented May 9, 2022

  • show result summary for each test result
  • minor table enhancements
  • use execa
  • implement delete a test result
  • results page, show summary

@@ -94,23 +91,6 @@ export const File = props => {
headers: {
'Content-Type': 'application/json'
}
}).then(res => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so long 🦀

@@ -232,8 +192,8 @@ export const Results = props => {
}}
variant="outline"
>
<Button>Previous</Button>
<Button>Next</Button>
<Button disabled>Previous</Button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should create issue for this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it then

@eric-hc eric-hc marked this pull request as ready for review May 10, 2022 15:24
@eric-hc eric-hc requested a review from a team as a code owner May 10, 2022 15:24
@eric-hc eric-hc marked this pull request as draft May 10, 2022 15:33
Comment on lines +68 to +73
<SidebarLink href="https://k6.io/docs" icon={<Mountain size={15} />}>
k6 docs
</SidebarLink>
<SidebarLink href="https://jslib.k6.io" icon={<Wrench size={15} />}>
jslib
</SidebarLink>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceeee

@eric-hc eric-hc marked this pull request as ready for review May 10, 2022 20:36
src/pages/api/results/[id].ts Outdated Show resolved Hide resolved
switch (method) {
case 'POST':
const { repoId, path, repo } = JSON.parse(req.body)
// is the test exist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHAT 🤨

Co-authored-by: Alexander Swanson <alexanderjswanson@icloud.com>
@eric-hc eric-hc merged commit fc895ae into main May 11, 2022
@eric-hc eric-hc deleted the result/summary branch May 11, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants