Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Stripe API version 2019-03-14 #484

Closed
kerryjj opened this issue Apr 30, 2019 · 7 comments
Closed

Support for Stripe API version 2019-03-14 #484

kerryjj opened this issue Apr 30, 2019 · 7 comments

Comments

@kerryjj
Copy link
Contributor

kerryjj commented Apr 30, 2019

Hi,

I'm considering upgrading stripe API versions to 2019-02-19 and/or 2019-03-14. I can't see any branches that might indicate they are available or being worked on already.

Are there plans to support these later versions? Do you know of anyone working on these already who I might be able to help out?

@snewcomer
Copy link
Collaborator

Ref #483

@kerryjj kerryjj changed the title Support for Stripe API version 2019-02-19 Support for Stripe API version 2019-03-14 May 1, 2019
@kerryjj
Copy link
Contributor Author

kerryjj commented May 1, 2019

OK Cheers @snewcomer

FYI: I'm currently working on upgrading our stripe API to 2019-03-14 and have a fork & branch that I'm currently testing out here:

https://github.com/blendmedia/stripity_stripe/tree/stripe-api/2019-03-14

Let me know if you'd eventually like me to submit this as a PR.

@snewcomer
Copy link
Collaborator

@kerryjj Looked through the commit history! Looks great! Mind making a PR with the last two? Would you mind reviewing #483 or should I close it in favor of your work? Honestly doesn't matter to me :). If you believe your work is better, I'd be super happy to close 483

@kerryjj
Copy link
Contributor Author

kerryjj commented May 7, 2019

I also don't mind either way as well. :)

Sorry I missed #483 before starting on these changes.

I see that there is some stuff that you've done in #483 that I haven't.

I'm not quite finished making changes to the branch I'm working on as I'm testing specific flows around creating custom stripe accounts and updating Person records.

Once I'm happy that my branch is working I'll create a PR that will be possible to merge into #384 without conflicts. I should be finished with testing it in the next few days.

@snewcomer
Copy link
Collaborator

@kerryjj Hi 👋 Any updates with your branch? Thanks for keeping this library in mind ;)

@dnsbty
Copy link
Contributor

dnsbty commented Jun 10, 2019

@snewcomer looks like this issue can probably be closed now

@kerryjj
Copy link
Contributor Author

kerryjj commented Jun 13, 2019

Hi guys, sorry I didn't get a chance to get back to this one.

Looks like you have the Person records now. Need anything from me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants