Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to rillig/sfntly.git (from googlei18n/sfntly.git) #13

Closed
ghost opened this issue Oct 14, 2017 · 6 comments
Closed

updating to rillig/sfntly.git (from googlei18n/sfntly.git) #13

ghost opened this issue Oct 14, 2017 · 6 comments

Comments

@ghost
Copy link

ghost commented Oct 14, 2017

hi,
googlei18n/sfntly is an archive for their old code,
the new code is placed in https://github.com/rillig/sfntly.git
(and I think it uses the same folder structure)

@bdusell
Copy link
Owner

bdusell commented Oct 14, 2017

Thanks for the heads-up! I wonder if we can get #6 fixed. I'll see about updating setup.

@ghost
Copy link
Author

ghost commented Oct 14, 2017

let me check,
I'm currently working on trying to convert few fonts anyway...
I might as well see if this alternative source will help with it.. :]

fetch_sfntly() {
  if [[ ! -d $SFNTLY_DIR ]]; then
    log 'Fetching sfntly...'
#   git clone https://github.com/googlei18n/sfntly.git "$SFNTLY_DIR"
    git clone https://github.com/rillig/sfntly.git "$SFNTLY_DIR"
...
...
...

@ghost
Copy link
Author

ghost commented Oct 15, 2017

ok.

slightly modified the setup for sfntly from https://github.com/rillig/sfntly.git
which uses maven instead of Ant.
so first:

fetch_sfntly() {
  if [[ ! -d $SFNTLY_DIR ]]; then
    log 'Fetching sfntly...'
#   git clone https://github.com/googlei18n/sfntly.git "$SFNTLY_DIR"
    git clone "https://github.com/rillig/sfntly.git" "$SFNTLY_DIR"
  fi
}
.......

and

build_sfntly() {
  log 'Building sfntly...'
  (cd "$SFNTLY_DIR"/java && mvn compile)
}
......

and

main() {
  require_command 'git' &&
  require_command 'java' &&
  require_command 'javac' &&
  require_command 'mvn' &&
.........

next, after maven-building sfntly, the Font.class and FontFactory.class will be placed in
webfont-generator-master/vendor/sfntly/java/target/classes/com/google/typography/font/sfntly
so webfont-generator-master/src/java/Makefile will be:

ConvertFont.class: ConvertFont.java
	javac -cp .:../../vendor/sfntly/java/target/classes/com/google/typography/font/sfntly $<
.......

compiled with linux Mint. seems fine.

(or http://central.maven.org/maven2/com/jaredrummler/sfntly/1.0.1/sfntly-1.0.1.jar )

@bdusell
Copy link
Owner

bdusell commented Oct 15, 2017

Great, feel free to submit a pull request.

@ghost
Copy link
Author

ghost commented Oct 16, 2017

...I avoid pull requests like the plague ;)

@ghost ghost closed this as completed Oct 16, 2017
@bdusell
Copy link
Owner

bdusell commented Oct 17, 2017

Leaving this open until I integrate this change.

@bdusell bdusell reopened this Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant