Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jellyfish Controller continually going 'unavailable' #20

Closed
markus99 opened this issue Apr 5, 2024 · 4 comments · Fixed by #24
Closed

Jellyfish Controller continually going 'unavailable' #20

markus99 opened this issue Apr 5, 2024 · 4 comments · Fixed by #24

Comments

@markus99
Copy link

markus99 commented Apr 5, 2024

I've hardwired the controller into my network, yet HA (~20+ times a day) shows as 'unavailable'

image

Possible to update so only if it's unavailable for >60 seconds it registers?

@bdunn44
Copy link
Owner

bdunn44 commented Apr 23, 2024

Hi there, thank you for reporting this issue. I checked my logs and have the same issue intermittently. And you're right, it's a timeout issue. Right now the integration polls the Jellyfish controller every 15 seconds for new data, and this request will time out if there's no response after 10 seconds. It seems the controller sometimes gets bogged down and doesn't respond in time - and 10 seconds is honestly an eternity!

Your proposed solution is definitely an option but would result in pretty high lag (i.e. there would be a >15s delay for any state changes to be reflected in HA if you were controlling lights via the Jellyfish app, for example). I'm thinking the best fix for this would be to move away from polling altogether and leverage the push updates that are sent via the controller. If the push updates work well - I don't see any reason why they wouldn't - it's also much more efficient for HA & your network, and state updates will reflect in HA instantaneously. A nice upgrade all around.

This has been on my mind for a while but I never got around to it because polling "just worked". Let me look into it, and fingers crossed, I'll release an update soon with push enabled.

@bdunn44
Copy link
Owner

bdunn44 commented Apr 24, 2024

Quick update, I modified the integration to enable push (781644e) and it seems to be working pretty well. The underlying library needs a slight upgrade though - I've submitted a PR that will need to be merged before this is released:

vinenoobjelly/jellyfishlights-py#10

@bdunn44
Copy link
Owner

bdunn44 commented Jun 3, 2024

@markus99 I just released version 1.3.0 which should address this. It's a beta release at the moment. Please give it a shot and reopen this issue and/or create a new one if you run into any trouble.

@markus99
Copy link
Author

markus99 commented Jun 4, 2024

Amazing, ty! Super slammed with work and family for a bit, so might be a delay reporting back, but will do asap. Nice work and ty again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants