Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioButton and CheckBox disabled text #861

Closed
WinXaito opened this issue Jun 14, 2023 · 2 comments · Fixed by #875
Closed

RadioButton and CheckBox disabled text #861

WinXaito opened this issue Jun 14, 2023 · 2 comments · Fixed by #875
Labels
enhancement New feature or request

Comments

@WinXaito
Copy link
Collaborator

Sometimes, I want to disable a text (with radio box, or checkbox, etc.)

So, I do something like that:

final replaceFileText = DefaultTextStyle.merge(
      child: const Text('Remplacer le fichier d\'origine'),
      style: TextStyle(color: FluentTheme
          .of(context)
          .disabledColor));

Result:

image

Maybe we can add an option disabled to Text ?

And maybe, for Radio and Checkbox, apply that to text automatically when onChanged is null.

@WinXaito WinXaito added the enhancement New feature or request label Jun 14, 2023
@bdlukaa
Copy link
Owner

bdlukaa commented Jun 14, 2023

Maybe we can add an option disabled to Text ?

I don't think this is possible, since Text comes from the flutter/widgets library.

For the other widgets, Buttons, PaneItem and a few more already make use of disabled when onChanged is null

For CheckBox and RadioButton, it can be added

@WinXaito
Copy link
Collaborator Author

I don't think this is possible, since Text comes from the flutter/widgets library.

Yeah I see, we can extends Text widget, but that's look crippy.

Keep this issue for Radio and Checkbox.

@WinXaito WinXaito changed the title Suggestion: text disabled RadioButton and CheckBox disabled text Jun 15, 2023
@bdlukaa bdlukaa mentioned this issue Jul 5, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants