Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendars Rework #236

Open
4 of 6 tasks
bdlukaa opened this issue Mar 23, 2022 · 6 comments
Open
4 of 6 tasks

Calendars Rework #236

bdlukaa opened this issue Mar 23, 2022 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bdlukaa
Copy link
Owner

bdlukaa commented Mar 23, 2022

The current implementation of both date and time pickers are old and have many issues.


  • Implement CalendarView
  • Implement CalendarDatePicker, based on CalendarView
@bdlukaa bdlukaa added enhancement New feature or request help wanted Extra attention is needed labels Mar 23, 2022
This was referenced Mar 25, 2022
@henry2man
Copy link
Contributor

Following DRY principles, can we ever consider use something curated like table_calendar as a base?

I have some experience with this one and this could simplify the ulterior development if we are able to render the calendar as expected in the spec.

@bdlukaa Do we have any specific policy about third party packages?

@bdlukaa
Copy link
Owner Author

bdlukaa commented Apr 2, 2022

As long as it's able to allow us to customizate it for our needs, I don't see any problem!

@henry2man
Copy link
Contributor

henry2man commented Apr 4, 2022

@bdlukaa So, in order to make things clear prior to any development:

  • Upstream references:
  • We want to create a new CalendarView, potentially based on table_calendar.
  • For this very first implementation we're going to have a minimal API:
    • CalendarView
      • initialValue: Show a defined month & Focus into that day (or DateTime.now() if not set)
      • minDate & maxDate: two optional DateTime args that limits min & max date (they will be unbounded if unset)
      • mandatory onSelect callback: function to be called when a day is selected
      • weekStartDay: First day of week (normally Sunday or Monday, depending on localization), defaults to Sunday.
      • UI: Change month using "up" and "down" buttons
      • UI: Use current locale to show current month & weekday tiles and also for formatting.
    • CalendarDatePicker
      • Display a form field with initialValue date (or DateTime.now() if not set)
      • On click, display a flyout with a CalendarView inside
      • When a day is clicked, hide the flyout and execute mandatory onChange callback

@bdlukaa bdlukaa mentioned this issue May 21, 2022
3 tasks
@henry2man
Copy link
Contributor

@bdlukaa Can we close this issue? What is missing?

@bdlukaa
Copy link
Owner Author

bdlukaa commented Jun 7, 2022

CalendarView:

@henry2man
Copy link
Contributor

Related: #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants