Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Wrong color on back button #204

Closed
WinXaito opened this issue Feb 25, 2022 · 6 comments
Closed

🐛 Wrong color on back button #204

WinXaito opened this issue Feb 25, 2022 · 6 comments
Labels
invalid This doesn't seem right

Comments

@WinXaito
Copy link
Collaborator

Light/dark color must be inverted on back button

sidebar_backbt

@WinXaito WinXaito added bug Something isn't working good first issue Good for newcomers labels Feb 25, 2022
@bdlukaa
Copy link
Owner

bdlukaa commented Feb 25, 2022

That's on purpose. If the button is enabled, the correct color is used

@WinXaito
Copy link
Collaborator Author

That's on purpose. If the button is enabled, the correct color is used

Okay, maybe add more difference ? Like a real disabled button, because like that, this is ... unpleasant to the eye

@bdlukaa bdlukaa removed the good first issue Good for newcomers label Feb 26, 2022
@henry2man
Copy link
Contributor

In this scenarios I always tend to use grey as neutral color because it's both visible in both light & dark modes.

But, to be honest, I've found a little bit weird having a disabled back button. Is this something inherited from Fluent UI?

@bdlukaa
Copy link
Owner

bdlukaa commented Mar 6, 2022

@henry2man take a look at the Settings app. If you haven't navigated yet, the back button is disabled!

@henry2man
Copy link
Contributor

@henry2man take a look at the Settings app. If you haven't navigated yet, the back button is disabled!

@bdlukaa Maybe I haven't explained myself well. What I find weird is having a back button disabled because in reality I would expect to see no button at all.

@bdlukaa
Copy link
Owner

bdlukaa commented Apr 2, 2022

What I find weird is having a back button disabled because in reality I would expect to see no button at all.

The button is disabled because there should be a "back" functionality. When pressing that button, any navigation previosly executed, either by Navigator.push or by changing the index on NavigationPane, should be undone. Learn more

Closing as invalid

@bdlukaa bdlukaa added invalid This doesn't seem right and removed bug Something isn't working labels Apr 2, 2022
@bdlukaa bdlukaa closed this as completed Apr 2, 2022
Repository owner locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants