-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report not able to handle base64 files when using all: true #280
Comments
@Toxicable interesting, if I'm understanding properly, this would be an artifact of running in a Bazel environment? If we see a path in this format should we simply decode the base64 blob, rather than reading the file path? Any chance you could send a failing test? |
Correct, something about how bazel + typescript is configured results in these paths. |
Aight was able to reproduce it https://github.com/Toxicable/rules_nodejs/tree/path-issue , here's the full error:
|
@Toxicable it looks like I can just decode the base64:
That path looks pretty weird though no? |
Yeah that's correct. That path is meant to look a bit weird :P |
@Toxicable I'll make an effort to pick this up soon, would also happily take a patch. I was figuring that I'd detect file paths that look like this, and use the Base64 encoded value -- ignoring the start of the path. |
Reports aren't able to read base64 source maps files
Looking at this line here: https://github.com/bcoe/c8/blob/master/lib/report.js#L189
It's not able to read files which have their content encoded as a base64 path.
Example:
path/to/file:application/json;base64,{base64 content}
Right now it'll throw an error like:
The text was updated successfully, but these errors were encountered: