Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit permissions for editing fire starts #1869

Closed
5 tasks
andrea-williams opened this issue Apr 7, 2022 · 2 comments
Closed
5 tasks

Add explicit permissions for editing fire starts #1869

andrea-williams opened this issue Apr 7, 2022 · 2 comments
Assignees
Labels
Ready User Story or Task Ready to be pulled into sprint User Story User story

Comments

@andrea-williams
Copy link
Collaborator

andrea-williams commented Apr 7, 2022

As an RWCO/ZWCO/maybe forecaster I want To be able to edit the predicted fire starts for a planning area So That I can complete a prep sheet for my planning area/fire centre.

As an non-RWCO/ZWCO I want To be able to view a prep sheet, including predicted fire starts So That I can know how bad things are going to be in my area/fire centre, but I should not be able to edit the fire starts because I cannot be trusted.

Additional Context

Acceptance Criteria

  • Given I am logged in as some user with {fire starts edit} rights, When I navigate to a fire centre in HFI Calc, Then the fire starts values for each planning area appear as a dropdown, and I am able to change the selected fire starts value, and my change should persist for all future users.
  • Given I am logged in as some user WITHOUT {fire starts edit} rights, When I navigate to a fire centre in HFI Calc, Then the fire starts values for each planning area appear as a non-editable text field (NOT a dropdown).
  • Given I am logged in as some user WITHOUT {fire starts edit} rights, When I try to hack the system by modifying the network request to a POST request with a modified fire starts value for a planning area, Then the POST request fails and my attempted changes are not persisted.
  • There exist unit tests covering all of the above AC.
  • Permissions are set up for users as specified by Dana's spreadsheet

Definition of Done

  • Ready to Demo in Sprint Review
  • Does what I have made have appropriate test coverage?
  • Documentation and/or scientific documentation exists and can be found
  • Peer Reviewed by 2 people on the team
  • Manual testing of all PRs in Dev and Prod
  • Merged
@andrea-williams andrea-williams added 4Refinement this ticket is ready for refinement with the team User Story User story labels Apr 7, 2022
@andrea-williams
Copy link
Collaborator Author

Hey team! Please add your planning poker estimate with ZenHub @conbrad @Sybrand

@conbrad conbrad added Ready User Story or Task Ready to be pulled into sprint and removed 4Refinement this ticket is ready for refinement with the team labels Apr 11, 2022
@conbrad conbrad self-assigned this Apr 11, 2022
@tessmgood
Copy link

Note: it is exclusively Plans in KFC who are changing fire starts. They export the PDF and share it with R/ZWCOs. If changes are needed, Plans makes the changes and re-distributes the PDF. (UXR session finding)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready User Story or Task Ready to be pulled into sprint User Story User story
Projects
None yet
Development

No branches or pull requests

3 participants