Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HFI Calc: All users see same information - the basics #1686

Closed
5 of 14 tasks
Sybrand opened this issue Feb 2, 2022 · 1 comment
Closed
5 of 14 tasks

HFI Calc: All users see same information - the basics #1686

Sybrand opened this issue Feb 2, 2022 · 1 comment
Assignees
Labels
Ready User Story or Task Ready to be pulled into sprint User Story User story

Comments

@Sybrand
Copy link
Contributor

Sybrand commented Feb 2, 2022

As a Z/RWCO I want everyone to see the same information So That there is no uncertainty and collaboration between Z/RWCOs is supported on prep morning

Additional Context

  • Changes to values such as FOP and are visible to all users.
  • Prep period is NOT persisted/saved - every time you go to the page, you have to select the period.
  • User's won't see changes other users are making until they re-load.
  • If multiple users are making changes at the same time, they may be over-writing each others changes.
  • There is a follow up ticket (HFI Calc: All users see same information vs. local changes  #1634) that addresses many UX issues.

Acceptance Criteria

  • Given I change a value in one of the select fields (fuel type, fire start), Then when I press the save button, the change will be persisted for all users.
  • Given I check/unhcheck a station, Then when I press the save button, the change will be persisted for all users.
  • Given a value in a select field has been saved, Then when I load data, I see the modified value.
  • Given a station has been check/unchecked and save has been clicked, Then when I load data, I see the modified value.

Additional tasks

  • Add more tests (don't have good tests to validate calculations at the moment)
  • Have to address the date nightmare on the front end. Too much jumping between different date time formats!!!
  • Some refactoring (moving code out of hfi router, to app.hfi module)
  • Other code cleanup

Definition of Done

  • Ready to Demo in Sprint Review
  • Does what I have made have appropriate test coverage?
  • Documentation and/or scientific documentation exists and can be found
  • Peer Reviewed by 2 people on the team
  • Manual testing of all PRs in Dev and Prod
  • Merged
@Sybrand Sybrand added User Story User story 4Refinement this ticket is ready for refinement with the team labels Feb 2, 2022
@nmathava
Copy link

nmathava commented Feb 2, 2022

Hey team! Please add your planning poker estimate with ZenHub @conbrad @JulianForeman @Sybrand

@nmathava nmathava added Ready User Story or Task Ready to be pulled into sprint and removed 4Refinement this ticket is ready for refinement with the team labels Feb 2, 2022
@Sybrand Sybrand self-assigned this Feb 2, 2022
@Sybrand Sybrand closed this as completed Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready User Story or Task Ready to be pulled into sprint User Story User story
Projects
None yet
Development

No branches or pull requests

2 participants