Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filings UI: implement Amalgamate button + selection panel #18805

Closed
10 tasks done
severinbeauvais opened this issue Nov 29, 2023 · 4 comments
Closed
10 tasks done

Filings UI: implement Amalgamate button + selection panel #18805

severinbeauvais opened this issue Nov 29, 2023 · 4 comments
Assignees
@JazzarKarim
Labels
ENTITY Business Team UX Assurance

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 29, 2023 •
edited by JazzarKarim
Loading

  • Initialize name option variable to NULL
  • add button to Entity Menu
  • use allowable actions for display or enable (see latest UI designs)
  • use business state for display or enable (see latest UI designs)
  • display tooltip(s)
  • implement 3 panels + buttons
  • keep horizontal and vertical buttons grayed out
  • create draft regular amalgamation only at this time
  • redirect to Create UI
  • Unit tests

UXPin: https://preview.uxpin.com/7f4cfe5fe4b0ba15a83d518177efe82a08e99167#/pages/160396524/simulate/sitemap
@severinbeauvais severinbeauvais added the ENTITY Business Team label Nov 29, 2023
@severinbeauvais severinbeauvais changed the title Filings UI: implement Amalgamate button Filings UI: implement Amalgamate button + selection panel Nov 29, 2023
@tronghieuvuong tronghieuvuong mentioned this issue Dec 1, 2023
Closed
@severinbeauvais
Copy link
Collaborator Author

Some questions are outstanding... waiting for future designs.

@tronghieuvuong tronghieuvuong mentioned this issue Dec 1, 2023
Closed
@severinbeauvais
Copy link
Collaborator Author

Updated designs are available. This ticket is now unblocked.

@JazzarKarim JazzarKarim self-assigned this Dec 13, 2023
This was referenced Dec 14, 2023
Merged
Merged
Merged
@jdyck-fw jdyck-fw added monitor and removed monitor labels Dec 20, 2023
@yuisotozaki
Copy link

Observations:

  • We want to add the Amalgamate button in the More Actions dropdown. This can be the last menu option item in the list.
  • The designer forgot to update the sentence at the top. Please update to just, "Choose the appropriate one for your filing."
  • The option card content text should be #212529
  • The padding needs some adjustment in the cards; 32px all around
  • The max spacing between the bottom of the Regular blurb to the top of the button should be 40px.

image.png

@JazzarKarim JazzarKarim mentioned this issue Dec 20, 2023
Merged
@yuisotozaki
Copy link

Ready for QA.

@severinbeauvais severinbeauvais mentioned this issue Dec 21, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JazzarKarim JazzarKarim

Labels
ENTITY Business Team UX Assurance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@severinbeauvais @yuisotozaki @jdyck-fw @Mihai-QuickSilverDev @JazzarKarim