Edit UI: Name Request Not Found on Coop IA Correction

[Mihai-QuickSilverDev]

• Environment - Test
• Start a Coop IA Correction
• Correct the name using a previously approved NR

Private Zenhub Image

• Upon submitting the Correction filing this error pops-up:

Private Zenhub Image

[Mihai-QuickSilverDev]

@severinbeauvais @kzdev420 I wonder if this is related to Kevin's latest work on transmitting NR details between different areas?

[severinbeauvais]

Yes, it's possible.

[severinbeauvais]

Is the subject name request NOT affiliated to the current account?

[Mihai-QuickSilverDev]

The NR was used straight into the Coop IA Correction, no pre-affiliation was done. It appears to me that the JSON is stripped of the NR validation details, causing this to fail.

[Mihai-QuickSilverDev]

• I have deleted the Coop IA Correction draft.
• Tried to affiliate the NR. This error pops up. System never asked for email or phone number.

Private Zenhub Image

[severinbeauvais]

We failed to handle this situation -- NR validation is done right before filing the correction, but no phone/email is used in the validation call to the API. We will need to store the phone/email and use it in that final NR validation.

[severinbeauvais]

• Tried to affiliate the NR. This error pops up. System never asked for email or phone number.

You are mixing apples and oranges.

In the MBR, since you are staff, no validation is done to affiliate the NR.

In the correction filing (Edit UI), a phone or email is required to fetch the NR. As mentioned above, we forgot to handle the pre-filing NR validation. This is a bug.

[severinbeauvais]

The MBR error was fixed but not pushed to Test yet.

Right, @seeker25 ?

[riyazuddinsyed]

@Mihai-QuickSilverDev The issue of not being able to do the Name change can you please test in dev.Kevin's fix is in dev and I haven't got to that ticket yet

[Mihai-QuickSilverDev]

@riyazuddinsyed Will do!

[seeker25]

Which MBR error?

[severinbeauvais]

Which MBR error?

The fix for fetching a NR from Legal API that required phone or email; now you fetch right from Namex API. Is that in Test? I'm wondering why Mihai's affiliation failed above.

[seeker25]

It's in PROD, and it was the flow where you register a business from Namerequest using a NR (turned out the flow Mihai was using used the same route).

[Mihai-QuickSilverDev]

@seeker25 Hi Travis, the error reported above in this ticket's description, is replicable both in Dev and Test. We are trying to understand what is causing it. Also, the NR used can be affiliated in Dev, but not in Test. It looks like your fix is in Dev and Prod, but not in Test?
@riyazuddinsyed @severinbeauvais

[seeker25]

it's deployed to DEV/TEST/PROD

Looks like I was wrong and it is related

Here's the problem:

2023-11-23 02:40:25,788 - auth_api - INFO in affiliation:affiliation.py:480 - _get_nr_details: 500 Server Error: Internal Server Error for url: https://namex-test.apps.silver.devops.gov.bc.ca/api/v1/requests/NR%202830003

[seeker25]

The entity service account on DEV had names-viewer role for the service account, but didn't have it on TEST. It has names-viewer on PROD. I've added names-viewer to TEST.

[severinbeauvais]

Mihai - we do understand what is causing the error in this ticket's description:

We failed to handle this situation -- NR validation is done right before filing the correction, but no phone/email is used in the validation call to the API. We will need to store the phone/email and use it in that final NR validation.