Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUSINESS-EDIT-UI - Correction - expects an SR to be present and crashes when it's absent #18495

Closed
danaannab opened this issue Nov 7, 2023 · 9 comments
Assignees
Labels
bug Something isn't working prod defect Relationships Work for Relationships team UX Assurance

Comments

@danaannab
Copy link
Collaborator

danaannab commented Nov 7, 2023

When a correction is launched for a coop, it should not assume a Special Resolution is on file for the business.

Note that there's a related ticket to make the SR section option for corrections. Linked below.

GIVEN I am filing a correction for a coop that has no Special Resolution in file
WHEN see the correction screen
THEN the special resolution text section will be hidden
AND the rules and memorandum sections will allow PDF upload

Design:
https://preview.uxpin.com/53053d7aeb85fb29915f7afa596429aea4f2a964#/pages/164803798/simulate/sitemap

@danaannab danaannab assigned danaannab and unassigned danaannab Nov 7, 2023
@danaannab danaannab added the bug Something isn't working label Nov 7, 2023
@danaannab
Copy link
Collaborator Author

@JohnamLane logged into IDIR account, encountered the error below while making a correction for CP1002512:

Private Zenhub Image

https://test.business.bcregistry.gov.bc.ca/CP1002512?accountid=1999
Browser: Chrome

Possible cause: correction assumes there will be a special resolution on file for each coop, but that's not the case. This coop was incorporated and then had an address change. No special resolution

Private Zenhub Image

@danaannab danaannab added the Relationships Work for Relationships team label Nov 7, 2023
@danaannab
Copy link
Collaborator Author

Ashna did regression testing on Monday. Checking with her if she got this error as per John.

@JohnamLane JohnamLane changed the title BUG : COOP Correction: Address Change BUG : COOP Correction expects an SR to be present and crashes when it's absent Nov 16, 2023
@JohnamLane
Copy link
Collaborator

@seeker25 seeker25 changed the title BUG : COOP Correction expects an SR to be present and crashes when it's absent BUSINESS-EDIT-UI / ENTITY-FILER - COOP Correction expects an SR to be present and crashes when it's absent Nov 29, 2023
@seeker25 seeker25 changed the title BUSINESS-EDIT-UI / ENTITY-FILER - COOP Correction expects an SR to be present and crashes when it's absent BUSINESS-EDIT-UI - COOP Correction expects an SR to be present and crashes when it's absent Nov 29, 2023
@seeker25 seeker25 changed the title BUSINESS-EDIT-UI - COOP Correction expects an SR to be present and crashes when it's absent BUSINESS-EDIT-UI - Correction - expects an SR to be present and crashes when it's absent Nov 29, 2023
@seeker25
Copy link
Collaborator

Ethan is discussing with the business for this one, it's a big can of worms

@seeker25
Copy link
Collaborator

seeker25 commented Nov 29, 2023

Private Zenhub Image

@seeker25
Copy link
Collaborator

@seeker25
Copy link
Collaborator

Private Zenhub Image

@seeker25
Copy link
Collaborator

bcgov/lear#2353 (review) <-- I think still needs to be addressed

@Jxio
Copy link
Collaborator

Jxio commented Dec 12, 2023

unit tests need fix on 2353, move back to in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prod defect Relationships Work for Relationships team UX Assurance
Projects
None yet
Development

No branches or pull requests

6 participants