Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legal API: Refactor code used to retrieve filing type fee codes #18479

Open
3 tasks
argush3 opened this issue Nov 6, 2023 · 0 comments
Open
3 tasks

Legal API: Refactor code used to retrieve filing type fee codes #18479

argush3 opened this issue Nov 6, 2023 · 0 comments
Labels
ENTITY Business Team techdebt

Comments

@argush3
Copy link
Collaborator

argush3 commented Nov 6, 2023 •
edited
Loading

The code in get_filing_types is a bit of a mess and is prone to introducing bugs.

Refactor it such that it is more generic and across filing types.

As an example, take a look at how future effective dates are currently handled.

TODOs

  • Analysis of how we can refactor code to be more generic
  • Refactor code
  • Add/update unit tests as req'd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ENTITY Business Team techdebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@argush3