Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity UI(s): remove obsolete FFs #18456

Closed
1 of 2 tasks
severinbeauvais opened this issue Nov 3, 2023 · 5 comments
Closed
1 of 2 tasks

Entity UI(s): remove obsolete FFs #18456

severinbeauvais opened this issue Nov 3, 2023 · 5 comments
Assignees
@severinbeauvais
Labels
ENTITY Business Team techdebt

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 3, 2023 •
edited
Loading

The following feature flags are True in all environments so they are no longer needed:

  • alteration-ui-enabled
  • change-ui-enabled
  • conversion-ui-enabled

To do:

  1. remove the FFs from all UIs (leave the True logic)
  2. archive/delete the FFs in LaunchDarkly once build has been deployed to Prod added step to release ticket
@severinbeauvais severinbeauvais changed the title Entity UI(s): remove alteration-ui-enabled FF Entity UI(s): remove obsolete FFs Nov 3, 2023
@severinbeauvais severinbeauvais self-assigned this Nov 9, 2023
@severinbeauvais severinbeauvais mentioned this issue Nov 9, 2023
Merged
@severinbeauvais
Copy link
Collaborator Author

Alteration UI Enabled FF is On across Dev/Test/Prod:

Private Zenhub Image

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Nov 9, 2023 •
edited
Loading

Change UI Enabled is On across Dev/Test/Prod:

Private Zenhub Image

@severinbeauvais
Copy link
Collaborator Author

Conversion UI Enabled FF is On across Dev/Test/Prod:

Private Zenhub Image

@severinbeauvais severinbeauvais mentioned this issue Nov 9, 2023
Closed
48 tasks
@severinbeauvais
Copy link
Collaborator Author

Test Notes

The 3 FF above were deleted from Edit UI, where they affected the startup of alteration, change, conversion and special resolution filings. However, the flags were enabled, so deleting them has no effect.

You can still verify that these filings start correctly. (You would see an alert and be redirected to the business dashboard if the flag was disabled or not working correctly.)

@severinbeauvais
Copy link
Collaborator Author

This is now merged and deployed to Dev and I have tested alterations there. Ready for QA.

This was referenced Nov 17, 2023
Closed
Closed
This was referenced Dec 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@severinbeauvais severinbeauvais

Labels
ENTITY Business Team techdebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@severinbeauvais @Mihai-QuickSilverDev