Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI - Remove Unregistered Business Proprietor Selection - SP/GP Registration #18449

Closed
1 of 3 tasks
Mihai-QuickSilverDev opened this issue Nov 3, 2023 · 16 comments
Closed
1 of 3 tasks
Assignees
Labels
ENTITY Business Team good first issue Good for newcomers UX Assurance

Comments

@Mihai-QuickSilverDev
Copy link
Collaborator

Mihai-QuickSilverDev commented Nov 3, 2023

To Do List:

Private Zenhub Image

@Mihai-QuickSilverDev Mihai-QuickSilverDev added ENTITY Business Team good first issue Good for newcomers blocked labels Nov 3, 2023
@jdyck-fw
Copy link
Collaborator

jdyck-fw commented Nov 6, 2023

Blocked on design, as the wording has to be updated as well.

@jdyck-fw
Copy link
Collaborator

jdyck-fw commented Nov 6, 2023

Mihai will create and link the UX ticket for this

@janisrogers
Copy link
Collaborator

Design is ready for dev

@janisrogers janisrogers changed the title Create UI - Remove Out of Province Proprietor Selection - SP/GP Registration Create UI - Remove Unregistered Business Proprietor Selection - SP/GP Registration Nov 8, 2023
@tshyun24 tshyun24 self-assigned this Nov 9, 2023
@tshyun24
Copy link

have a quick question: Does this UI page only appears for GP/SP Registration, or other type of registration will also direct to this UI page? In other words, does GP/SP Registration have a unique UI than other type
image

@janisrogers
Copy link
Collaborator

As far as I know it is only for SP/GP

@tshyun24
Copy link

image
image
image
Looks like that now for a SP👀

@tshyun24
Copy link

tshyun24 commented Nov 14, 2023

@severinbeauvais Hi Severin, I have a small question, seems like since we want to change the label at here
image
But it's under bcrs-shared-components repo, so should I create a new ticket under this repo and make changes or?
image

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 14, 2023

Shaoyun, did you want to pass the label as a prop to this shared component?

Here is the GH link to the component. Go ahead and make the change and PR it under your current ticket. There are instructions on workflow in the repo's README file.

https://github.com/bcgov/bcrs-shared-components/blob/main/src/components/business-lookup/BusinessLookup.vue

... And ask if you need help. (You will need help to publish the updated component. See readme for details.)

@tshyun24
Copy link

tshyun24 commented Nov 14, 2023

Shaoyun, did you want to pass the label as a prop to this shared component?

I think we should pass the whole class at here (just as what we did previously),
image

Go ahead and make the change and PR it under your current ticket.

Got it! Thanks Severin

@Mihai-QuickSilverDev
Copy link
Collaborator Author

Mihai-QuickSilverDev commented Nov 16, 2023

@tshyun24 Hi Shaoyun,

  • Could you just mask it out for now, but keep it available if we want to bring it in later?
  • Also, the link needs to remain in place if the registration is done by Staff (BC Registries or SBC)

@janisrogers
Copy link
Collaborator

@Mihai-QuickSilverDev - Only BC Registries Staff, not SBC

@Mihai-QuickSilverDev
Copy link
Collaborator Author

I have crossed out SBC above.

@severinbeauvais
Copy link
Collaborator

Shaoyun, FYI: "SBC" refers to "Service BC". These front-counter staff have special roles (in account object) but are not "BCROS staff". Look for code referencing this in Create UI to implement this appropriately for this ticket.

@tshyun24
Copy link

Shaoyun, FYI: "SBC" refers to "Service BC". These front-counter staff have special roles (in account object) but are not "BCROS staff". Look for code referencing this in Create UI to implement this appropriately for this ticket.

Sure Severin, the new commit should have meet the requirement, just working with the git control

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 20, 2023

I am assuming this ticket's changes won't be ready by mid-day today, so they will not get deployed to Test. Hence I am removing the Release 19.5a label.

update: it will be in this release after all

@yuisotozaki
Copy link

Ready for QA.

This was referenced Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team good first issue Good for newcomers UX Assurance
Projects
None yet
Development

No branches or pull requests

6 participants