Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colin API - remove colin api auth on/off FF #17820

Closed
6 tasks done
argush3 opened this issue Sep 20, 2023 · 1 comment
Closed
6 tasks done

Colin API - remove colin api auth on/off FF #17820

argush3 opened this issue Sep 20, 2023 · 1 comment
Assignees
Labels
ENTITY Business Team good first issue Good for newcomers

Comments

@argush3
Copy link
Collaborator

argush3 commented Sep 20, 2023

  • Do in main branch
  • Do this once COLIN API has been exposed externally.
  • We do not want the option to be able to turn auth off once the COLIN API is exposed externally.
  • Remove custom decorator for Auth for all endpoints
  • Add standard auth decorator used for all apis and filter by COLIN_SVC_ROLE
  • Testing can be done in Dev after merging the code.
@argush3 argush3 added the ENTITY Business Team label Sep 20, 2023
@argush3 argush3 changed the title Remove colin api auth on/off FF Colin API - remove colin api auth on/off FF Sep 20, 2023
@argush3 argush3 removed the blocked label Nov 9, 2023
@Mihai-QuickSilverDev Mihai-QuickSilverDev added the good first issue Good for newcomers label Nov 9, 2023
@kzdev420 kzdev420 self-assigned this Nov 15, 2023
@kzdev420
Copy link
Collaborator

Hi

Private Zenhub Image

To fix the current lint issue, that line should be updated like this.
pylint. remove this <=2.3.1
Then it will install the pylint-3.0.2-py3-none-any.whl

I checked it gets rid of AttributeError: module 'astroid' has no attribute 'TryExcept'. but there are some new lint-errors that should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants