Filings UI: Admin Freeze should not show on ledger

[davemck513]

When an entity is frozen this should not show on the ledger.
Staff should still be able to add comments.
Any existing Freezes should be removed from the ledger.

Requirements located here: https://docs.google.com/presentation/d/14ZPjw-VT2kniECBEMqc5E_jBW6TxV6HA/edit#slide=id.gf495bffbf0_0_14

To Do List:

• When freeze is applied, do not create a ledger entry.
• When freeze is applied, display the Frozen flag/message on the entity's dashboard.
• When freeze is removed, do not create a ledger entry.
• When freeze is removed, remove the Frozen flag/message from the entity's dashboard.

Example:

Private Zenhub Image

[severinbeauvais]

This can be handled by the Legal API (by not providing the ledger entry for display)... unless we want to provide it to API users? @thorwolpert

[jdyck-fw]

Pinning this for consideration for 18.2

[argush3]

Was thinking we update the BE to provide a flag to indicate whether a filing should be displayed on the ledger. The UI will need be updated to make use of this. Thoughts @severinbeauvais @thorwolpert ?

[severinbeauvais]

I think that makes sense. Would this flag be in the business data from Legal API to Auth API/Web (not in the filings response)?

(What is this data going from Legal API to Auth... a queue message? Or an endpoint call? And who makes it -- Auth API or Auth Web? Maybe both need to be updated.)

Update: irrelevant comments! See new comment below.

[argush3]

I don't think it will be in the business response if I'm understanding your question correctly.

This flag will be specific to a filing. So the displayLedger flag can be returned in the GET /filings and GET /filings/<filing_id> endpoints I think.

I was thinking just add a dictionary to the BE that defines filings that shouldn't be displayed on the ledger. And these two filing endpoints will just use to set the flag accordingly.

At the end of the day, for our use case, we probably only need to update the GET /filings endpoint.

Examples

GET /filings endpoint

GET /filings/<filing_id> endpoint

[thorwolpert]

We decided a while back not to add hide/open ledger items.
If it changes data on a business, it's on the ledger.
afaik, an admin freeze is not a data change, but could be a data change if it was part of a Registrar's Entry which would include a reason as to why a business was frozen (like maybe it was frozen before being struck for using a fraudulent credit card. But that there are other non-published reasons to freeze it.
Also by "change data" that refers to the items we track due to legislation or Registry policies.
Like we add a filing / ledger item when we change and existing BN to a new number

[severinbeauvais]

Argus, I was confused -- never mind my last comment!

Yes, Business Filings UI would need a small change to not show this filing in the ledger, according to your new flag.

[Mihai-QuickSilverDev]

@elizabethanneespinosa Hi Elizabeth, could you please re-confirm the reason behind not showing an Admin Freeze on the ledger? My understanding is that we are trying to avoid having the clients calling BC Registries, and questioning our actions. Instead the communication for missed payment, which is usually a reason for the freeze, would take place on different channels.

[elizabethanneespinosa]

https://docs.google.com/presentation/d/14ZPjw-VT2kniECBEMqc5E_jBW6TxV6HA/edit#slide=id.gf495bffbf0_0_14 this show the history of the requirements as captured by Sarah E. Let me know if you have any questions.

[severinbeauvais]

This ticket can be implemented but not tested until #18490 is implemented.

[severinbeauvais]

From description:

Staff should still be able to add comments.

Where should staff add comments? Not to the "Admin Freeze" (or "Admin Unfreeze") ledger items since we're removing them.

[Mihai-QuickSilverDev]

Staff would add comments, at any moment, as needed, here highlighted below, independent of the Freeze/Unfreeze filings themselves.

Private Zenhub Image

[severinbeauvais]

OK, perfect, thanks.

[elizabethanneespinosa]

@Mihai-QuickSilverDev any update on this one?

[MeganFedora]

@Mihai-QuickSilverDev @davemck513 are there any updates on this one please?

[severinbeauvais]

@davemck513 @Mihai-QuickSilverDev Should we show the freeze and unfreeze filings in the ledger to staff users? If not, how will they see any detail comments that they put in?

(We could move/copy the freeze/unfreeze comments to the staff comments section but that would require extra code changes.)

[Mihai-QuickSilverDev]

@severinbeauvais This was discussed before in this ticket. No comments would be handled part of the freeze/unfreeze filing. Staff would go separately and use the Staff comments already existing on the Entity's dashboard.

[severinbeauvais]

Thanks, Mihai. Yes, I found the conversation on Nov 7, 2023.

BTW, as this ticket is no longer blocked, we should perhaps move it to the current sprint.